Review Request: Fix crash when closing Amarok with running CoverFetcher

Ralf Engels ralf-engels at gmx.de
Thu Aug 9 10:36:26 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105942/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

childBarFinished was called with invalid m_progressDetailsWidget
However also the m_progressMap needs protection. The CompoundProgressBar needs to be thread safe.


This addresses bug 292553.
    https://bugs.kde.org/show_bug.cgi?id=292553


Diffs
-----

  src/statusbar/CompoundProgressBar.h baaab94 
  src/statusbar/CompoundProgressBar.cpp 371a534 

Diff: http://git.reviewboard.kde.org/r/105942/diff/


Testing
-------

Change is verified by me to fix the problem.


Thanks,

Ralf Engels

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120809/8cb362eb/attachment-0001.html>


More information about the Amarok-devel mailing list