Review Request: Removes unnecessary OpenGL constraints from the spectrum analyzer

[David Smith]

> On Aug. 3, 2012, 7:14 a.m., David Smith wrote:
> > Fixed the error, but the Spectrum Analyzer still doesn't show up or work.
> > KDE 4.8.4
> > Amarok 2.6
> > Radeon Mobility X700 (Gallium r300g / OpenGL 2.1)
> >

Ok, I was wrong, this patch fixes the Spectrum Analyzer. I just needed to use the GStreamer backend to feed the Spectrum Analyzer some data.  The VLC backend looks like it's missing some components to make the spectrum analyzer work so that's why I was getting nothing.  The patch removes the error and when combined with the GStreamer backend, the Spectrum Analyzer now works...

I now say, ship this patch.

Mobility X700


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104330/#review16808
-----------------------------------------------------------


On March 18, 2012, 1:46 p.m., Daniel Dewald wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104330/
> -----------------------------------------------------------
> 
> (Updated March 18, 2012, 1:46 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Removes some unnecessary OpenGL constraints from the spectrum analyzer (See Bug# 290327). Also extended the remaining constraints error messages to clarify that its an OpenGL problem.
> 
> 
> This addresses bug 290327.
>     https://bugs.kde.org/show_bug.cgi?id=290327
> 
> 
> Diffs
> -----
> 
>   src/context/applets/spectrumanalyzer/SpectrumAnalyzerApplet.cpp 8d5ad25 
> 
> Diff: http://git.reviewboard.kde.org/r/104330/diff/
> 
> 
> Testing
> -------
> 
> Since my graphic card supports all the removed constraints I can't really test if the problem is gone now. Someone with an older card should test if the error message is gone now.
> 
> 
> Thanks,
> 
> Daniel Dewald
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20120809/fd4cb15a/attachment.html>