<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104330/">http://git.reviewboard.kde.org/r/104330/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 3rd, 2012, 7:14 a.m., <b>David Smith</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed the error, but the Spectrum Analyzer still doesn't show up or work.
KDE 4.8.4
Amarok 2.6
Radeon Mobility X700 (Gallium r300g / OpenGL 2.1)
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I was wrong, this patch fixes the Spectrum Analyzer. I just needed to use the GStreamer backend to feed the Spectrum Analyzer some data. The VLC backend looks like it's missing some components to make the spectrum analyzer work so that's why I was getting nothing. The patch removes the error and when combined with the GStreamer backend, the Spectrum Analyzer now works...
I now say, ship this patch.
Mobility X700
</pre>
<br />
<p>- David</p>
<br />
<p>On March 18th, 2012, 1:46 p.m., Daniel Dewald wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Daniel Dewald.</div>
<p style="color: grey;"><i>Updated March 18, 2012, 1:46 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removes some unnecessary OpenGL constraints from the spectrum analyzer (See Bug# 290327). Also extended the remaining constraints error messages to clarify that its an OpenGL problem.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since my graphic card supports all the removed constraints I can't really test if the problem is gone now. Someone with an older card should test if the error message is gone now.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=290327">290327</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/context/applets/spectrumanalyzer/SpectrumAnalyzerApplet.cpp <span style="color: grey">(8d5ad25)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104330/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>