Review Request: Fix audio CD's discovery at amarok's startup (bug 276032)

[Luc Menut]

> On Sept. 12, 2011, 12:08 p.m., Sam Lade wrote:
> > First of all, thanks for looking at this - I know it's been annoying a lot of our users.
> > 
> > It doesn't seem to be working reliably for me. Sometimes an audio CD is correctly shown on startup, but a lot of the time it doesn't work. Mostly it seems to work after first insertion of the audio CD, but after a couple of Amarok startups it ceases to do so for subsequent starts. I can't get any reliable trigger for this happening, however.
> > 
> > I'm running Amarok Git (it's not that far from 2.4.3 at the moment) on KDE 4.7.0 and Qt 4.7.2 on Kubuntu. I can provide any relevant sections of the debug output if you wish (give me things to grep for, or I can just dump the lot if you can find it), or any other debugging info you're after.

Thanks for the feedback. Sadly, I can't reproduce here the problem; I started/stopped/started amarok several times with an audio CD in the CD drive, and the audio CD always appears correctly in Local Music (without the patch the audio CD only appears if the audio CD is inserted when amarok is already running).
Just to be sure we are speaking of the same things, by Collection viewer, I mean the left panel "Media Sources" and not the Playlist (cf screenshot). I know that "amarok --cdplay" still doesn't work properly, and most of the time doesn't add automatically the CD tracks in the playlist.
I haven't the time to build Amarok from git for now. Perhaps, it could be interesting to have feedback from others users on others systems/distribs.

--
Luc Menut
Mageia Contributor


- Luc


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102580/#review6439
-----------------------------------------------------------


On Sept. 11, 2011, 4:40 p.m., Luc Menut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102580/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2011, 4:40 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Currently, Amarok does not list the Audio CD in the Collection viewer if the CD is already in the drive when amarok starts.
> 
> 
> I don't have write access to kde git, so could you commit the change for me if the patch looks fine. Thanks.
> 
> regards,
> Luc
> 
> 
> This addresses bug 276032.
>     https://bugs.kde.org/show_bug.cgi?id=276032
> 
> 
> Diffs
> -----
> 
>   src/MediaDeviceCache.cpp 70868a6 
> 
> Diff: http://git.reviewboard.kde.org/r/102580/diff
> 
> 
> Testing
> -------
> 
> I tested this patch with Amarok 2.4.1 (Mageia 1) and Amarok 2.4.3 (Mageia Cauldron).
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102580/s/255/
> 
> 
> Thanks,
> 
> Luc
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110912/1fb503d0/attachment.html>