Review Request: Fix audio CD's discovery at amarok's startup (bug 276032)

[Sam Lade]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102580/#review6439
-----------------------------------------------------------


First of all, thanks for looking at this - I know it's been annoying a lot of our users.

It doesn't seem to be working reliably for me. Sometimes an audio CD is correctly shown on startup, but a lot of the time it doesn't work. Mostly it seems to work after first insertion of the audio CD, but after a couple of Amarok startups it ceases to do so for subsequent starts. I can't get any reliable trigger for this happening, however.

I'm running Amarok Git (it's not that far from 2.4.3 at the moment) on KDE 4.7.0 and Qt 4.7.2 on Kubuntu. I can provide any relevant sections of the debug output if you wish (give me things to grep for, or I can just dump the lot if you can find it), or any other debugging info you're after.

- Sam


On Sept. 11, 2011, 4:40 p.m., Luc Menut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102580/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2011, 4:40 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Currently, Amarok does not list the Audio CD in the Collection viewer if the CD is already in the drive when amarok starts.
> 
> 
> I don't have write access to kde git, so could you commit the change for me if the patch looks fine. Thanks.
> 
> regards,
> Luc
> 
> 
> This addresses bug 276032.
>     https://bugs.kde.org/show_bug.cgi?id=276032
> 
> 
> Diffs
> -----
> 
>   src/MediaDeviceCache.cpp 70868a6 
> 
> Diff: http://git.reviewboard.kde.org/r/102580/diff
> 
> 
> Testing
> -------
> 
> I tested this patch with Amarok 2.4.1 (Mageia 1) and Amarok 2.4.3 (Mageia Cauldron).
> 
> 
> Thanks,
> 
> Luc
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110912/f2dabdd4/attachment.html>