Review Request: iPod connection assistant: rework iPod identification

Matěj Laitl matej at laitl.cz
Tue Oct 25 13:20:29 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102966/
-----------------------------------------------------------

Review request for Amarok, Christophe Giboudeaux and Bart Cerneels.


Description
-------

iPod connection assistant: rework iPod identification

This should fix remaining bugs where iPod is misidentified as a USB
stick. Long comments are added that clarify interaction of varous
code paths that deal with iPhone-like devices.

BUG: 263288
REVIEW: TODO
FIXED-IN: 2.5


Diffs
-----

  ChangeLog a99a4de75b1941ecdc7cb3b41cce9ad3c996df27 
  src/MediaDeviceCache.cpp 345837e34e5505c0900ee1a4e66ae9cf3deafa31 
  src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp fecd07a8db2cb3eead184ec3a12198fe02124074 

Diff: http://git.reviewboard.kde.org/r/102966/diff/diff


Testing
-------

iPod nano 2G and iPod nano 4G are correctly identified.


Thanks,

Matěj Laitl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111025/dfea3551/attachment.html>


More information about the Amarok-devel mailing list