Review Request: Add new collection filter to find exact matches

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102252/#review7586
-----------------------------------------------------------


I like the feature, but the syntax seems little incoherent wrt current one, specifically the greater-than and smaller-than variants e.g. playcount:<3 or track:>10. I know these are numeric values, but being coherent counts. What about field:=value? (I must admit it looks a bit weird, let's see what others will say)

Please do the gui (this has additional benefit of telling user that artist:something is a "contains" match) and I'll be happy to merge this once other Amarok devs agree.

- Matěj Laitl


On Aug. 8, 2011, 2:38 p.m., Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102252/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2011, 2:38 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Since I use labels quite intensive it sometimes comes handy to search for songs with an exact label, not just a label containing the string I'm searching for.
> So I added a new filter type for this and used the '=' sign.
> 
> Searching for label=pop finds songs labeled with 'pop' but not with 'electro pop'.
> While searching for label:pop finds songs labeled with 'pop' and 'electro pop'.
> 
> This is not integrated into the GUI like the EditFilterDialog since I wanted to hear your opinions first.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/support/Expression.h 1e49f45 
>   src/core-impl/collections/support/Expression.cpp 531850a 
>   src/core-impl/collections/support/TextualQueryFilter.cpp 735772b 
> 
> Diff: http://git.reviewboard.kde.org/r/102252/diff/diff
> 
> 
> Testing
> -------
> 
> I'm using this patch for a few weeks now without any problems.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102252/s/221/
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111024/5168533e/attachment.html>