Fwd: Amarok v2.4.3 doesn't build

[Mark Kretschmann]

---------- Forwarded message ----------
From: Alexander Neundorf <neundorf at kde.org>
Date: Wed, Oct 19, 2011 at 12:32 AM
Subject: Amarok v2.4.3 doesn't build
To: Harald Sitter <sitter at kde.org>, kretschmann at kde.org
Cc: kde-buildsystem at kde.org


Hi,

I just tried to build amarok from the v2.4.3 tag from git and it failed !!!!
;-)

I tries to link against -L/usr/lib/mysql -lmysqld, but there is no
libmysqld.so (probably because the development package is not installed).

The problem is in FindMySqlAmarok.cmake.
If mysql_config is found, it is queried for the flags necessary for linking
(mysql_config --libmysqld-lib), and its output is simply put into the
MYSQL_EMBEDDED_LIBRARIES variable.

I think here goes the same as with pkg-config: never use the output from such
tools directly, but always double check, i.e. if it says "mysqld" is in
/usr/lib/mysql/, do a
find_library(MYSQL_LIBRARY NAMES mysqld HINTS /usr/lib/mysqld)
and use what you get from that.
This way, cmake will always have to deal with full paths to libraries, and can
takle care that everything will link properly.

Can you please have a look at that file (FindMySqlAmarok.cmake) ?

Thanks
Alex

P.S. this is slightly related to the current question how to handle pkg-config
under Windows and/or in general, so I'm putting kde-buildsystem on CC.



-- 
Mark Kretschmann
Amarok Developer, Senior Software Engineer at Nokia
Fellow of the Free Software Foundation Europe
http://amarok.kde.org - http://fsfe.org - http://nokia.com