Review Request: [GSoC] Amarok integration with gpodder.net (GPodder stuff)

Stefan Derkits stefan at derkits.at
Sat Oct 15 22:20:19 UTC 2011


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Lucas,

tried the PodcastProvider now that it is in Master.

Fixed some Stuff (use of #DEFINES instead of constants & creation of
own nam), but found some serious Problems:

It uploads an EpisodeAction::PLAY every minute, which is not correct.
Play should only be sent once to the Webservice, when I
stop/pause/seek (not sure about seek, @stefankoegl can you clarify?)
and not every minute.
Please change this asap, cause if more users start using the gpodder
service in Amarok the gpodder Server will receive too many requests.

Also after restarting amarok and starting a podcast episode again from
the start, the time in the EpisodeActions seem to be counted from the
last point where I stopped it and not from the beginning (also try to
find a way to set the start always to 00:00, it is always 00:01).

Stefan
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iEYEARECAAYFAk6aByMACgkQlZvAMV/NgGLjcgCgkIAsUvT9IXWvp0b0qO8lnT2u
P14AoJmnL4cDmuTKTMFGleIpzapj1B29
=Kux6
-----END PGP SIGNATURE-----


More information about the Amarok-devel mailing list