Review Request: [GSoC] Amarok integration with gpodder.net (Playlist synchronisation stuff)

[Bart Cerneels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102846/#review7307
-----------------------------------------------------------

Ship it!


I'm committing the changes to XSPFPlaylist and M3UPlaylist separate.




ChangeLog
<http://git.reviewboard.kde.org/r/102846/#comment6388>

    Newest changes go on top.
    I will fix this when committing.



src/browsers/playlistbrowser/PodcastModel.h
<http://git.reviewboard.kde.org/r/102846/#comment6389>

    These 2 functions need to go.
    As far as I can tell you use them to access the master of a SyncedPodcast in data(). Using the master data needs to be implemented SyncedPodcast.
    
    Will need to be fixed post-commit.



src/playlistmanager/SyncRelationStorage.cpp
<http://git.reviewboard.kde.org/r/102846/#comment6390>

    This is a hack. No special cases allowed.
    
    Will have to be fixed after committing.


- Bart Cerneels


On Oct. 13, 2011, 9:25 p.m., Lucas Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102846/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2011, 9:25 p.m.)
> 
> 
> Review request for Amarok, Stefan Derkits and Bart Cerneels.
> 
> 
> Description
> -------
> 
> The attached diff is the work done during this summer to integrate gpodder.net web service with Amarok.
> Notice that this diff have only playlist synchronisation service related stuff.
> 
> 
> Diffs
> -----
> 
>   ChangeLog 14422b1 
>   src/CMakeLists.txt 962070d 
>   src/browsers/playlistbrowser/PlaylistBrowserModel.h 76ccb10 
>   src/browsers/playlistbrowser/PlaylistBrowserModel.cpp ff18d83 
>   src/browsers/playlistbrowser/PodcastModel.h ce1a86f 
>   src/browsers/playlistbrowser/PodcastModel.cpp 4aad518 
>   src/browsers/playlistbrowser/QtGroupingProxy.cpp e0b4e7a 
>   src/core-impl/playlists/types/file/PlaylistFileSupport.cpp 2dcc0cd 
>   src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp c64cb97 
>   src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp 0a3c99a 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.h 0110911 
>   src/core-impl/podcasts/sql/SqlPodcastMeta.cpp e88bc9e 
>   src/core-impl/podcasts/sql/SqlPodcastProvider.cpp 83e9b99 
>   src/core/playlists/Playlist.h f88b070 
>   src/core/podcasts/PodcastMeta.h 21364b4 
>   src/core/podcasts/PodcastMeta.cpp fb82fa8 
>   src/main.cpp 7306e84 
>   src/playlistmanager/PlaylistManager.h 54d63b1 
>   src/playlistmanager/PlaylistManager.cpp 333ff17 
>   src/playlistmanager/SyncRelationStorage.h 2a2681d 
>   src/playlistmanager/SyncRelationStorage.cpp b151243 
>   src/playlistmanager/SyncedPlaylist.h 54914c7 
>   src/playlistmanager/SyncedPlaylist.cpp c8383b5 
>   src/playlistmanager/SyncedPodcast.h PRE-CREATION 
>   src/playlistmanager/SyncedPodcast.cpp PRE-CREATION 
>   src/playlistmanager/file/KConfigSyncRelStore.h 4674f66 
>   src/playlistmanager/file/KConfigSyncRelStore.cpp a857593 
>   src/playlistmanager/file/PlaylistFileProvider.cpp 728030d 
>   src/playlistmanager/sql/SqlPlaylist.cpp b2a9ca5 
> 
> Diff: http://git.reviewboard.kde.org/r/102846/diff/diff
> 
> 
> Testing
> -------
> 
> This patch is the result of git diff for the range of several commits prior to HEAD, rebased on current master, and should build. Everything is working as expected and there aren't any known issues.
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111014/dca7ba2f/attachment.html>