Review Request: Avoid using deleted BookmarkTriangles or null BookmarkPopups (should fix 283753)

[Charles Reiss]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102830/
-----------------------------------------------------------

Review request for Amarok.


Description
-------

This fixes two potential memory errors with BookmarkTriangle. (1) BookmarkTriangles are currently deleted with qDeleteAll(), when they can probably have pending events (leave/enter) in the event queue, and (2) the m_tooltip member of BookmarkTriangle can probably be null if things are racy enough.


This addresses bug 283753.
    https://bugs.kde.org/show_bug.cgi?id=283753


Diffs
-----

  src/widgets/BookmarkTriangle.cpp 8845704 
  src/widgets/SliderWidget.cpp ffb9726 

Diff: http://git.reviewboard.kde.org/r/102830/diff/diff


Testing
-------

Attempted to reproduce 283753 (which I could do semireliably by mousing over a bookmark a lot while playing a track that Phonon seems to like updating the length of) after patching.


Thanks,

Charles Reiss

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111011/f24d944d/attachment.html>