Review Request: Avoid memory error in MP4TagHelper::embeddedCover() (bug 283675)

[Charles Reiss]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102828/
-----------------------------------------------------------

(Updated Oct. 13, 2011, 4:25 a.m.)


Review request for Amarok.


Description
-------

Don't access Taglib::MP4::CoverArt objects from an out of scope TagLib::MP4::CoverArtList.


This addresses bug 283675.
    https://bugs.kde.org/show_bug.cgi?id=283675


Diffs (updated)
-----

  shared/tag_helpers/MP4TagHelper.cpp 4226081 

Diff: http://git.reviewboard.kde.org/r/102828/diff/diff


Testing
-------

Verified that adding MP4 file with embedded cover art to playlist (that crashed before patch on my OS X setup) did not crash after patching.


Thanks,

Charles Reiss

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111013/2565f49d/attachment.html>