Review Request: Avoid memory error in MP4TagHelper::embeddedCover() (bug 283675)

[Sergey Ivanov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102828/#review7252
-----------------------------------------------------------



shared/tag_helpers/MP4TagHelper.cpp
<http://git.reviewboard.kde.org/r/102828/#comment6308>

    Nope, this is not the same thing. Originaly function tried to find largest picture (that is why variable was called maxSize :) ), but now It will return first one that bigger then 1024.


- Sergey Ivanov


On Oct. 11, 2011, 4:48 p.m., Charles Reiss wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102828/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2011, 4:48 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Don't access Taglib::MP4::CoverArt objects from an out of scope TagLib::MP4::CoverArtList.
> 
> 
> This addresses bug 283675.
>     https://bugs.kde.org/show_bug.cgi?id=283675
> 
> 
> Diffs
> -----
> 
>   shared/tag_helpers/MP4TagHelper.cpp 4226081 
> 
> Diff: http://git.reviewboard.kde.org/r/102828/diff/diff
> 
> 
> Testing
> -------
> 
> Verified that adding MP4 file with embedded cover art to playlist (that crashed before patch on my OS X setup) did not crash after patching.
> 
> 
> Thanks,
> 
> Charles Reiss
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111012/a3bf1b2a/attachment.html>