Review Request: Fix audio CD's discovery by MediaDeviceCache::refreshCache() at amarok's startup (bug 276032)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102580/#review8295
-----------------------------------------------------------


This review has been submitted with commit 49ce96b92bb1a78086624d5500cb9b06196613b9 by Sam Lade to branch master.

- Commit Hook


On Oct. 9, 2011, 10:39 p.m., Luc Menut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102580/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2011, 10:39 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Currently, Amarok does not list the Audio CD in the Collection viewer if the CD is already in the drive when amarok starts. The audio CD is not detected by MediaDeviceCache::refreshCache() at startup (if the CD is already in the drive when amarok starts), but is correctly detected by MediaDeviceCache::slotAddSolidDevice( const QString &udi ) when the CD is inserted in the drive when amarok is running.
> 
> 
> I don't have write access to kde git, so could you commit the change for me if the patch looks fine. Thanks.
> 
> regards,
> Luc
> 
> 
> This addresses bug 276032.
>     https://bugs.kde.org/show_bug.cgi?id=276032
> 
> 
> Diffs
> -----
> 
>   src/MediaDeviceCache.cpp 70868a6 
> 
> Diff: http://git.reviewboard.kde.org/r/102580/diff/diff
> 
> 
> Testing
> -------
> 
> I tested this patch with Amarok 2.4.1 (Mageia 1) and Amarok 2.4.3 (Mageia Cauldron).
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102580/s/255/
> 
> 
> Thanks,
> 
> Luc Menut
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111118/876bba50/attachment.html>