Review Request: make all like conditions case insensitive

Commit Hook null at kde.org
Sat Nov 5 19:40:49 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103015/#review7971
-----------------------------------------------------------


This review has been submitted with commit be77608b9ba0386c3bfc6f1d7daa78b80dd48826 by Daniel Faust to branch master.

- Commit Hook


On Nov. 1, 2011, 3:15 p.m., Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103015/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2011, 3:15 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> When creating a sql like condition and booth, the beginning and the ending of the string have to match, the comparison is case sensitive.
> I haven't seen it being used until my proposed patch to add a new collection filter to exactly do that. (http://git.reviewboard.kde.org/r/102252/)
> But I would suggest using case insensitivity there, too.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/sql/SqlQueryMaker.cpp 398bcdc 
> 
> Diff: http://git.reviewboard.kde.org/r/103015/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111105/0e848430/attachment.html>


More information about the Amarok-devel mailing list