Review Request: make all like conditions case insensitive

[Matěj Laitl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103015/#review7970
-----------------------------------------------------------

Ship it!


Looks fine to me, previous behaviour was too convoluted IMO. (case-isensitive on '%something%' and case-sensitive on 'somehing' queries)

- Matěj Laitl


On Nov. 1, 2011, 3:15 p.m., Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103015/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2011, 3:15 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> When creating a sql like condition and booth, the beginning and the ending of the string have to match, the comparison is case sensitive.
> I haven't seen it being used until my proposed patch to add a new collection filter to exactly do that. (http://git.reviewboard.kde.org/r/102252/)
> But I would suggest using case insensitivity there, too.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/db/sql/SqlQueryMaker.cpp 398bcdc 
> 
> Diff: http://git.reviewboard.kde.org/r/103015/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111105/ab66529e/attachment.html>