Review Request: Re-Add old "Normal" moodbar style

[Bart Cerneels]

> On Nov. 4, 2011, 7:43 a.m., Bart Cerneels wrote:
> > src/moodbar/MoodbarManager.cpp, line 337
> > <http://git.reviewboard.kde.org/r/103036/diff/1/?file=40181#file40181line337>
> >
> >     We should use an Enum here, not hardcoded numerical values.
> >     
> >     If you add this it's OK to commit.

Has to be done this weekend since we have the 2.5 string freeze coming up.


- Bart


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103036/#review7931
-----------------------------------------------------------


On Nov. 3, 2011, 9:22 p.m., Florian Eßer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103036/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2011, 9:22 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> This patch re-adds the old pre-2.4.0 moodbar "Normal" style as a fifth option in the moodbar style selection dialog.
> 
> Sorry to reheat the old topic from https://bugs.kde.org/show_bug.cgi?id=264432, but upgrading to Kubuntu 11.10 (overwriting my self-compiled Amarok version) made me recognize that this bug is still not fixed.
> The old "Normal" style was and is *not* the (IMHO ugly) happy style, so 82d102ba32e0a1b6a154dfe4653e786229c0dcb7 did not really fix the bug. Please have a look at the attached screenshot for a comparison of the different moodbar styles.
> 
> 
> This addresses bug 264432.
>     https://bugs.kde.org/show_bug.cgi?id=264432
> 
> 
> Diffs
> -----
> 
>   src/configdialog/dialogs/GeneralConfig.ui 14b2d63 
>   src/moodbar/MoodbarManager.cpp 53bea15 
> 
> Diff: http://git.reviewboard.kde.org/r/103036/diff/diff
> 
> 
> Testing
> -------
> 
> worksforme
> 
> 
> Screenshots
> -----------
> 
> Comparison of different moodbar styles.
>   http://git.reviewboard.kde.org/r/103036/s/322/
> 
> 
> Thanks,
> 
> Florian Eßer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111104/f5ae844d/attachment-0001.html>