Review Request: Done some improvements on Gpodder Service

[Stefan Derkits]

> On Nov. 3, 2011, 8:34 a.m., Bart Cerneels wrote:
> > src/services/gpodder/GpodderProvider.cpp, line 1046
> > <http://git.reviewboard.kde.org/r/103034/diff/1/?file=40173#file40173line1046>
> >
> >     What about the other possible episode actions?

also it looks that you still only send the latest and don't cache the other episode actions (but this could also be done for 2.6)


- Stefan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103034/#review7891
-----------------------------------------------------------


On Nov. 3, 2011, 12:02 a.m., Lucas Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103034/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2011, 12:02 a.m.)
> 
> 
> Review request for Amarok, Stefan Derkits and Bart Cerneels.
> 
> 
> Description
> -------
> 
> Done some improvements on GPodder Service.
> 
> Fixes:
> * Annoying popup related to KIO (wrapper around QNetworkAccessManager) (Seems that the libmygpo-qt version fixed it)
> * GPodderProvider can be loaded in runtime also.
> * Preserve persistence of GPodderService EpisodeActions during shutdown and restart of Amarok. 
> * Now, we send EpisodeActions in Amarok start or when a user stop/pause and doesn't resume listening in 60 seconds.
> 
> Know bugs:
> * Even though GpodderProvider can be loaded during runtime, the PodcastBrowser is not showing it :/.
> 
> 
> Diffs
> -----
> 
>   ChangeLog 0b87f8e 
>   src/services/gpodder/GpodderProvider.h 8ddc802 
>   src/services/gpodder/GpodderProvider.cpp 15996f8 
>   src/services/gpodder/GpodderService.h 02ff539 
>   src/services/gpodder/GpodderService.cpp 9e04d38 
>   src/services/gpodder/GpodderServiceConfig.cpp 5ff6dea 
>   src/services/gpodder/GpodderServiceSettings.h fa53387 
>   src/services/gpodder/GpodderServiceSettings.cpp 51ab598 
> 
> Diff: http://git.reviewboard.kde.org/r/103034/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Lucas Gomes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111103/8b23f79f/attachment.html>