<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103034/">http://git.reviewboard.kde.org/r/103034/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 3rd, 2011, 8:34 a.m., <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103034/diff/1/?file=40173#file40173line1046" style="color: black; font-weight: bold; text-decoration: underline;">src/services/gpodder/GpodderProvider.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void GpodderProvider::loadEpisodeActions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">986</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">EpisodeAction</span><span class="o">::</span><span class="n">Play</span><span class="p">,</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about the other possible episode actions?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">also it looks that you still only send the latest and don't cache the other episode actions (but this could also be done for 2.6)</pre>
<br />
<p>- Stefan</p>
<br />
<p>On November 3rd, 2011, 12:02 a.m., Lucas Gomes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok, Stefan Derkits and Bart Cerneels.</div>
<div>By Lucas Gomes.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2011, 12:02 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done some improvements on GPodder Service.
Fixes:
* Annoying popup related to KIO (wrapper around QNetworkAccessManager) (Seems that the libmygpo-qt version fixed it)
* GPodderProvider can be loaded in runtime also.
* Preserve persistence of GPodderService EpisodeActions during shutdown and restart of Amarok.
* Now, we send EpisodeActions in Amarok start or when a user stop/pause and doesn't resume listening in 60 seconds.
Know bugs:
* Even though GpodderProvider can be loaded during runtime, the PodcastBrowser is not showing it :/.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ChangeLog <span style="color: grey">(0b87f8e)</span></li>
<li>src/services/gpodder/GpodderProvider.h <span style="color: grey">(8ddc802)</span></li>
<li>src/services/gpodder/GpodderProvider.cpp <span style="color: grey">(15996f8)</span></li>
<li>src/services/gpodder/GpodderService.h <span style="color: grey">(02ff539)</span></li>
<li>src/services/gpodder/GpodderService.cpp <span style="color: grey">(9e04d38)</span></li>
<li>src/services/gpodder/GpodderServiceConfig.cpp <span style="color: grey">(5ff6dea)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.h <span style="color: grey">(fa53387)</span></li>
<li>src/services/gpodder/GpodderServiceSettings.cpp <span style="color: grey">(51ab598)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103034/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>