Review Request: Add new collection filter to find exact matches

[Daniel Faust]

> On Nov. 2, 2011, 9:49 a.m., Matěj Laitl wrote:
> > src/core-impl/collections/support/TextualQueryFilter.cpp, line 110
> > <http://git.reviewboard.kde.org/r/102252/diff/2/?file=40006#file40006line110>
> >
> >     Daniel, when you're at it (and when http://git.reviewboard.kde.org/r/103014/ is here), could you please apply the TODO and call Meta::fieldForName() everythere instead of ad-hoc comparisons?

Yep, I'll just do it after http://git.reviewboard.kde.org/r/103014/


- Daniel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102252/#review7864
-----------------------------------------------------------


On Nov. 1, 2011, 3:02 p.m., Daniel Faust wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102252/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2011, 3:02 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Description
> -------
> 
> Since I use labels quite intensive it sometimes comes handy to search for songs with an exact label, not just a label containing the string I'm searching for.
> So I added a new filter type for this and used the '=' sign.
> 
> Searching for label=pop finds songs labeled with 'pop' but not with 'electro pop'.
> While searching for label:pop finds songs labeled with 'pop' and 'electro pop'.
> 
> This is not integrated into the GUI like the EditFilterDialog since I wanted to hear your opinions first.
> 
> 
> Diffs
> -----
> 
>   src/core-impl/collections/support/Expression.h 1e49f45 
>   src/core-impl/collections/support/Expression.cpp 531850a 
>   src/core-impl/collections/support/TextualQueryFilter.cpp 735772b 
>   src/dialogs/EditFilterDialog.cpp 91628ff 
>   src/widgets/MetaQueryWidget.h 3db49d3 
>   src/widgets/MetaQueryWidget.cpp 5db1ded 
> 
> Diff: http://git.reviewboard.kde.org/r/102252/diff/diff
> 
> 
> Testing
> -------
> 
> I'm using this patch for a few weeks now without any problems.
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/102252/s/221/
> 
> 
> Thanks,
> 
> Daniel Faust
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111102/74287a92/attachment.html>