<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102252/">http://git.reviewboard.kde.org/r/102252/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 2nd, 2011, 9:49 a.m., <b>Matěj Laitl</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/102252/diff/2/?file=40006#file40006line110" style="color: black; font-weight: bold; text-decoration: underline;">src/core-impl/collections/support/TextualQueryFilter.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Collections::addTextualFilter( Collections::QueryMaker *qm, const QString &filter )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">108</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ADD_OR_EXCLUDE_FILTER</span><span class="p">(</span> <span class="n">Meta</span><span class="o">::</span><span class="n">valAlbum</span><span class="p">,</span> <span class="n">elem</span><span class="p">.</span><span class="n">text</span><span class="p">,</span> <span class="kc"><span class="hl">false</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="kc"><span class="hl">false</span></span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">110</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ADD_OR_EXCLUDE_FILTER</span><span class="p">(</span> <span class="n">Meta</span><span class="o">::</span><span class="n">valAlbum</span><span class="p">,</span> <span class="n">elem</span><span class="p">.</span><span class="n">text</span><span class="p">,</span> <span class="n"><span class="hl">matchEqual</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">matchEqual</span></span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Daniel, when you're at it (and when http://git.reviewboard.kde.org/r/103014/ is here), could you please apply the TODO and call Meta::fieldForName() everythere instead of ad-hoc comparisons?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep, I'll just do it after http://git.reviewboard.kde.org/r/103014/</pre>
<br />
<p>- Daniel</p>
<br />
<p>On November 1st, 2011, 3:02 p.m., Daniel Faust wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Daniel Faust.</div>
<p style="color: grey;"><i>Updated Nov. 1, 2011, 3:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since I use labels quite intensive it sometimes comes handy to search for songs with an exact label, not just a label containing the string I'm searching for.
So I added a new filter type for this and used the '=' sign.
Searching for label=pop finds songs labeled with 'pop' but not with 'electro pop'.
While searching for label:pop finds songs labeled with 'pop' and 'electro pop'.
This is not integrated into the GUI like the EditFilterDialog since I wanted to hear your opinions first.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm using this patch for a few weeks now without any problems.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/support/Expression.h <span style="color: grey">(1e49f45)</span></li>
<li>src/core-impl/collections/support/Expression.cpp <span style="color: grey">(531850a)</span></li>
<li>src/core-impl/collections/support/TextualQueryFilter.cpp <span style="color: grey">(735772b)</span></li>
<li>src/dialogs/EditFilterDialog.cpp <span style="color: grey">(91628ff)</span></li>
<li>src/widgets/MetaQueryWidget.h <span style="color: grey">(3db49d3)</span></li>
<li>src/widgets/MetaQueryWidget.cpp <span style="color: grey">(5db1ded)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102252/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/102252/s/221/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/08/08/filter_equals_artist_400x100.jpg" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>