Review Request: Notify others of new metadata

Ralf Engels ralf-engels at gmx.de
Sun May 15 14:34:46 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100967/#review3334
-----------------------------------------------------------

Ship it!


Looks sensible.

I say ship it.

- Ralf


On March 29, 2011, 10:56 a.m., Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100967/
> -----------------------------------------------------------
> 
> (Updated March 29, 2011, 10:56 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This patch makes it so that Amarok emits the propertyChanged() signal for the Metadata property whenever the track changes. Without this change, metadata is not displayed in Ubuntu Sound Menu.
> 
> 
> Diffs
> -----
> 
>   src/dbus/mpris2/Mpris2DBusHandler.cpp bd69a05 
> 
> Diff: http://git.reviewboard.kde.org/r/100967/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110515/f84dc8a5/attachment-0001.htm 


More information about the Amarok-devel mailing list