Review Request: Fix: Recently played tracks are not updated in currrent track applet.

[Ralf Engels]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101015/#review3318
-----------------------------------------------------------


When the track is stopped you should get the trackChanged signal (with the new track being empty). So that should update the lastPlayed time.
Actually you might want to wait a little bit after the "trackChanged" signal in case that the currentTrack Applet slot get's called before the collection had time to update the change.

Also if you stop the track to early it's not counted as being played.

So having a timer every minute seems to be unneeded.
Can you change the timer to a one shot timer being started after "trackChanged"?
Also is there a bug report about this problem?

- Ralf


On April 4, 2011, 5:23 p.m., Conrad Hübler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101015/
> -----------------------------------------------------------
> 
> (Updated April 4, 2011, 5:23 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> The recentlyplayedtracks-widget from the current track applet does not update the last played time of recently played tracks. It now happens, every 60000 msec and after amarok stops.
> 
> It is just a hack for the next release making this applet working as it should, but it is not a proper solution for this problem.
> 
> 
> Diffs
> -----
> 
>   src/context/widgets/RecentlyPlayedListWidget.h b9b3d3b 
>   src/context/widgets/RecentlyPlayedListWidget.cpp 2959c1c 
> 
> Diff: http://git.reviewboard.kde.org/r/101015/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Conrad
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110514/ecd1d9c8/attachment-0001.htm