Review Request: Fixing E-Mail RegExp in LikeBack Dialog
Ralf Engels
ralf-engels at gmx.de
Sat May 14 13:42:22 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101170/#review3316
-----------------------------------------------------------
Ship it!
Looks fine
- Ralf
On April 21, 2011, 4:35 p.m., Michael Düll wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101170/
> -----------------------------------------------------------
>
> (Updated April 21, 2011, 4:35 p.m.)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> This fixes the RegExp checking in the LikeBack system in amarok-git to support fully RFC conform local-parts of email addresses.
>
> This is my first submitted patch. I hope I've done things right.
>
>
> Diffs
> -----
>
> src/likeback/LikeBackDialog.cpp b53dec5
>
> Diff: http://git.reviewboard.kde.org/r/101170/diff
>
>
> Testing
> -------
>
> Tested with git version without a problem.
>
>
> Thanks,
>
> Michael
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110514/6fbbfd4b/attachment.htm
More information about the Amarok-devel
mailing list