Fwd: Review Request: Fix incorrect slot names in gpodder service which causes "no such slot" runtime error

[Mark Kretschmann]

---------- Forwarded message ----------
From: <romain.perier at gmail.com>
Date: Sun, Mar 27, 2011 at 4:55 PM
Subject: Review Request: Fix incorrect slot names in gpodder service which
causes "no such slot" runtime error
To: Mark Kretschmann <kretschmann at kde.org>, Harald Sitter <
sitter.harald at gmail.com>
Cc: romain.perier at gmail.com


   This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6639/
  Review request for Harald Sitter and Mark Kretschmann.
By bambi.
Description

When you use the gpodder service with amarok 2.4.0.90 sometimes when
you click on podcast entries you can see the following messages in a
terminal:
QObject::connect: No such slot
GpodderPodcastRequestHandler::topTagsRequestError(QNetworkReply::NetworkError)
QObject::connect: No such slot GpodderPodcastRequestHandler::topTagsParseError()

These slots do not exist in GpodderPodcastRequestHandler API. Change
them to requestError(QNetworkReply::NetworkError) and parserError()
solves the problem.
See the patch in attachment.

  Diffs

   - src/services/gpodder/GpodderServiceModel.cpp (af48576)

View Diff <http://svn.reviewboard.kde.org/r/6639/diff/>



-- 
Mark Kretschmann
Amarok Developer, Senior Software Engineer at Nokia
Fellow of the Free Software Foundation Europe
http://amarok.kde.org - http://fsfe.org - http://nokia.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110329/8209ad98/attachment.htm