<br><br><div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername"></b> <span dir="ltr"><<a href="mailto:romain.perier@gmail.com">romain.perier@gmail.com</a>></span><br>Date: Sun, Mar 27, 2011 at 4:55 PM<br>
Subject: Review Request: Fix incorrect slot names in gpodder service which causes "no such slot" runtime error<br>To: Mark Kretschmann <<a href="mailto:kretschmann@kde.org">kretschmann@kde.org</a>>, Harald Sitter <<a href="mailto:sitter.harald@gmail.com">sitter.harald@gmail.com</a>><br>
Cc: <a href="mailto:romain.perier@gmail.com">romain.perier@gmail.com</a><br><br><br>
<div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6639/" target="_blank">http://svn.reviewboard.kde.org/r/6639/</a>
</td>
</tr>
</tbody></table>
<br>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-repeat:repeat-x;border:1px black solid">
<tbody><tr>
<td>
<div>Review request for Harald Sitter and Mark Kretschmann.</div>
<div>By bambi.</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">When you use the gpodder service with amarok 2.4.0.90 sometimes when you click on podcast entries you can see the following messages in a terminal:
QObject::connect: No such slot GpodderPodcastRequestHandler::topTagsRequestError(QNetworkReply::NetworkError)
QObject::connect: No such slot GpodderPodcastRequestHandler::topTagsParseError()
These slots do not exist in GpodderPodcastRequestHandler API. Change them to requestError(QNetworkReply::NetworkError) and parserError() solves the problem.
See the patch in attachment.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>src/services/gpodder/GpodderServiceModel.cpp <span style="color:grey">(af48576)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6639/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div>
</div>
</div><br><br clear="all"><br>-- <br>Mark Kretschmann<br>Amarok Developer, Senior Software Engineer at Nokia<br>Fellow of the Free Software Foundation Europe<br><a href="http://amarok.kde.org" target="_blank">http://amarok.kde.org</a> - <a href="http://fsfe.org" target="_blank">http://fsfe.org</a> - <a href="http://nokia.com" target="_blank">http://nokia.com</a><br>