Review Request: fix detection of IPod Classic (at least)

[Cristi P]

No svn commit access, so I guess you might have to help by committing it :-(

Regards.


On Sun, Mar 20, 2011 at 12:32 PM, Rick W. Chen <stuffcorpse at archlinux.us>wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100889/
>
> Ship it!
>
> Looks good. Works well. Do you have commit access?
>
>
> - Rick W.
>
> On March 20th, 2011, 8:35 a.m., Cristi Posoiu wrote:
>   Review request for Amarok.
> By Cristi Posoiu.
>
> *Updated March 20, 2011, 8:35 a.m.*
> Description
>
> Using KDE 4.6.1 (Mandriva Cooker, x86_64) and Amarok 2.4.0.
> It seems I have the same problem people are complaining in http://forum.kde.org/viewtopic.php?f=115&t=93018
>
> Amarok sees my ipod only as a simple usb storage disk, even though in it there are those particular directories and files (iPod_Control/, SysExtendedInfo, etc).
> When plugging, I get /dev/sdb1 mounted.
> Running solid-hardware list details, KDE Solid is returning for it a Vendor name ("Apple") and as product, since it is a partition, the partition label.
> As such, code from .../support/IpodConnectionAssistant.cpp can't match it.
> In Solid data, /dev/sdb shows though the appropriate product string ("iPod").
>
> So, what this code does, is that it tries to do that product string matching also on parent's device.
>
>
>   Testing
>
> started amarok and I get to see my ipod + everything on it.
>
>   Diffs
>
>    - src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp
>    (92339ff)
>
> View Diff <http://git.reviewboard.kde.org/r/100889/diff/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110320/6ab683f7/attachment.htm