No svn commit access, so I guess you might have to help by committing it :-(<br><br>Regards.<br><br><br><div class="gmail_quote">On Sun, Mar 20, 2011 at 12:32 PM, Rick W. Chen <span dir="ltr"><<a href="mailto:stuffcorpse@archlinux.us">stuffcorpse@archlinux.us</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div>
<div style="font-family:Verdana, Arial, Helvetica, Sans-Serif"><div class="im">
<table style="border:1px #c9c399 solid" width="100%" bgcolor="#f9f3c9" cellpadding="8">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100889/" target="_blank">http://git.reviewboard.kde.org/r/100889/</a>
</td>
</tr>
</tbody></table>
<br>
</div><p>Ship it!</p>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Looks good. Works well. Do you have commit access?</pre>
<br>
<p>- Rick W.</p><div class="im">
<br>
<p>On March 20th, 2011, 8:35 a.m., Cristi Posoiu wrote:</p>
</div><table style="background-repeat:repeat-x;border:1px black solid" width="100%" bgcolor="#fefadf" cellpadding="8" cellspacing="0">
<tbody><tr>
<td><div class="im">
<div>Review request for Amarok.</div>
<div>By Cristi Posoiu.</div>
<p style="color:grey"><i>Updated March 20, 2011, 8:35 a.m.</i></p>
</div><h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1><div class="im">
<table style="border:1px solid #b8b5a0" width="100%" bgcolor="#ffffff" cellpadding="10" cellspacing="0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Using KDE 4.6.1 (Mandriva Cooker, x86_64) and Amarok 2.4.0.
It seems I have the same problem people are complaining in <a href="http://forum.kde.org/viewtopic.php?f=115&t=93018" target="_blank">http://forum.kde.org/viewtopic.php?f=115&t=93018</a>
Amarok sees my ipod only as a simple usb storage disk, even though in it there are those particular directories and files (iPod_Control/, SysExtendedInfo, etc).
When plugging, I get /dev/sdb1 mounted.
Running solid-hardware list details, KDE Solid is returning for it a Vendor name ("Apple") and as product, since it is a partition, the partition label.
As such, code from .../support/IpodConnectionAssistant.cpp can't match it.
In Solid data, /dev/sdb shows though the appropriate product string ("iPod").
So, what this code does, is that it tries to do that product string matching also on parent's device.
</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" width="100%" bgcolor="#ffffff" cellpadding="10" cellspacing="0">
<tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">started amarok and I get to see my ipod + everything on it.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
</div><div class="im"><ul style="margin-left:3em;padding-left:0">
<li>src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp <span style="color:grey">(92339ff)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100889/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</div></td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div><br>