Review Request: New context applet, displays all albums in a cover grid view

[Manu Wagner]

> On June 6, 2011, 12:04 p.m., Kevin Funk wrote:
> > Okay, so far so good. We're getting there ;)
> > 
> > Two other remarks that prevent your patch from being applied.
> > * Please fix the look of your applet when you have albums with no cover set, there's still some gray bg showing up, it seems. Looks a bit 
> > * I'd recommend disabling the horizontal scrollbar completely and fill up the space that's actually there.
> > 
> > Other than that, looks fine.
> 
> Manu Wagner wrote:
>     about the "no cover" problem, could it be that when applying the patch you're not getting the "defaultcover.png" image which should show up in that case ?
>     as for the horizontal scrollbar, I'll try my best ;)
> 
> Manu Wagner wrote:
>     ...which isn't enough :(
>     I can't seem to handle the applet width properly.
>     Do you really think it's worth the fuss ?
> 
> Manu Wagner wrote:
>     hi,
>     Albums without cover are working at my end.
>     The case is handled using the "defaultcover.png" image.How am I meant to deliver those files in a patch file ?
>     As for the sliders, I don't know how to do it, and it's a non blocking issue to me...

bump...


- Manu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100841/#review3719
-----------------------------------------------------------


On June 5, 2011, 3:55 p.m., Manu Wagner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100841/
> -----------------------------------------------------------
> 
> (Updated June 5, 2011, 3:55 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Added a new context applet, called CoverGrid.
> It displays all albums of the collection by their cover art in a grid view.
> Tooltips display album & artist names, mouse double click appends album to playlist
> 
> 
> Diffs
> -----
> 
>   src/context/applets/CMakeLists.txt 25b3f0b 
>   src/context/applets/covergrid/AlbumItem.h PRE-CREATION 
>   src/context/applets/covergrid/AlbumItem.cpp PRE-CREATION 
>   src/context/applets/covergrid/CMakeLists.txt PRE-CREATION 
>   src/context/applets/covergrid/CoverGridApplet.h PRE-CREATION 
>   src/context/applets/covergrid/CoverGridApplet.cpp PRE-CREATION 
>   src/context/applets/covergrid/amarok-context-applet-covergrid.desktop PRE-CREATION 
>   src/context/applets/covergrid/covergridSettings.ui PRE-CREATION 
>   src/context/applets/covergrid/defaultcover.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100841/diff
> 
> 
> Testing
> -------
> 
> basic functionalities seem to work
> 
> 
> Screenshots
> -----------
> 
> new applet in action
>   http://git.reviewboard.kde.org/r/100841/s/96/
> 
> 
> Thanks,
> 
> Manu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110619/527382d7/attachment-0001.htm