Review Request: tag reading support for s3m, it and xm files

[Mathias Stephan Panzenböck]

> On June 15, 2011, 11:30 a.m., Bart Cerneels wrote:
> > Style and logic looks OK to me. I can't comment on the functionality since I'm pretty much clueless about collectionscanner and taglib.

Currently I'm in the process of getting this into taglib (see the taglib pull request). So maybe this patch should not be applied as-is but you should wait for taglib to finally pull my changes (they will be reviewed next week - I hope I've time to write more unit tests for it over the weekend). Then I'll adapt this patch so it does not depend on taglib-mod but on a certain taglib version that includes module file support.

Btw. I added support for .mod files to my taglib fork in the meantime. I don't think I'll maintain the separate taglib-mod but wait for taglib to merge my changes. I just use taglib-mod with amarok locally in the meantime. :)


- Mathias Stephan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101598/#review3900
-----------------------------------------------------------


On June 13, 2011, 1:59 a.m., Mathias Stephan Panzenböck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101598/
> -----------------------------------------------------------
> 
> (Updated June 13, 2011, 1:59 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This patch adds read-only tag support for s3m, it and xm files. It uses a taglib extension library I wrote (TagLib-Mod):
> https://bitbucket.org/panzi/taglib-mod
> 
> This library is a soft dependency. If it is not found the feature is not compiled.
> 
> I've also sent a pull request to the taglib project:
> https://github.com/taglib/taglib/pull/4
> 
> 
> This addresses bug 90524.
>     https://bugs.kde.org/show_bug.cgi?id=90524
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d1abe26 
>   shared/FileType.h 5c8081f 
>   shared/FileType.cpp a6e25d5 
>   shared/tag_helpers/TagHelper.cpp 96f763e 
>   src/App.cpp 48ba1d9 
>   src/CMakeLists.txt b5b5689 
>   src/core-impl/collections/db/sql/CMakeLists.txt dac9598 
>   utilities/collectionscanner/CMakeLists.txt e712485 
> 
> Diff: http://git.reviewboard.kde.org/r/101598/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mathias Stephan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110617/55144fed/attachment.htm