<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101598/">http://git.reviewboard.kde.org/r/101598/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 15th, 2011, 11:30 a.m., <b>Bart Cerneels</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Style and logic looks OK to me. I can't comment on the functionality since I'm pretty much clueless about collectionscanner and taglib.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently I'm in the process of getting this into taglib (see the taglib pull request). So maybe this patch should not be applied as-is but you should wait for taglib to finally pull my changes (they will be reviewed next week - I hope I've time to write more unit tests for it over the weekend). Then I'll adapt this patch so it does not depend on taglib-mod but on a certain taglib version that includes module file support.
Btw. I added support for .mod files to my taglib fork in the meantime. I don't think I'll maintain the separate taglib-mod but wait for taglib to merge my changes. I just use taglib-mod with amarok locally in the meantime. :)</pre>
<br />
<p>- Mathias Stephan</p>
<br />
<p>On June 13th, 2011, 1:59 a.m., Mathias Stephan Panzenböck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Mathias Stephan Panzenböck.</div>
<p style="color: grey;"><i>Updated June 13, 2011, 1:59 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds read-only tag support for s3m, it and xm files. It uses a taglib extension library I wrote (TagLib-Mod):
https://bitbucket.org/panzi/taglib-mod
This library is a soft dependency. If it is not found the feature is not compiled.
I've also sent a pull request to the taglib project:
https://github.com/taglib/taglib/pull/4</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=90524">90524</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d1abe26)</span></li>
<li>shared/FileType.h <span style="color: grey">(5c8081f)</span></li>
<li>shared/FileType.cpp <span style="color: grey">(a6e25d5)</span></li>
<li>shared/tag_helpers/TagHelper.cpp <span style="color: grey">(96f763e)</span></li>
<li>src/App.cpp <span style="color: grey">(48ba1d9)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b5b5689)</span></li>
<li>src/core-impl/collections/db/sql/CMakeLists.txt <span style="color: grey">(dac9598)</span></li>
<li>utilities/collectionscanner/CMakeLists.txt <span style="color: grey">(e712485)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101598/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>