Review Request: New context applet, displays all albums in a cover grid view

[Kevin Funk]

> On May 18, 2011, 6:52 p.m., Ralf Engels wrote:
> > Hi,
> > nice, but I would not know what do do with it.
> > It seems like a cover-bling applet (which by the way currently crashes for me)
> > 
> > Could you maybe make a "cover-view" applet that can be switched between the different views?
> 
> Manu Wagner wrote:
>     Hi,
>     It's definitely a good idea : a single applet enabling to toggle either grid or flow thing.
>     But now that I think about it, it might be a bit of a hassle...As multiple QObject inheritance does not seem to be allowed, this would imply merging both main applet sources. Not sure we'd like to do that, actually.
>     What's your opinion ?
> 
> Manu Wagner wrote:
>     Given the debate on the coverbling applet, my opinion is that we should separate it from the covergrid applet, at least until we eventually decide to release the coverbling as well.

Manu Wagner, could you please update your review? I think it makes sense to merge it, since coverbling is not going to be shipped anyway at its current state.

I got some remarks for you:
* Style: Please consider HACKING/intro_and_style.txt to match our coding style
  * Notable issues with your patch: Whitespace issues in argument lists, header ordering
  * Use the correct list of copyright holders (you, noone else, I guess)
* Ensure that the widget looks good when you only have a small amount of albums
* Modify the parent CMakeLists.txt and add your directory


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100841/#review3388
-----------------------------------------------------------


On March 11, 2011, 9:47 p.m., Manu Wagner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100841/
> -----------------------------------------------------------
> 
> (Updated March 11, 2011, 9:47 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Added a new context applet, called CoverGrid.
> It displays all albums of the collection by their cover art in a grid view.
> Tooltips display album & artist names, mouse double click appends album to playlist
> 
> 
> Diffs
> -----
> 
>   src/context/applets/covergrid/AlbumItem.h PRE-CREATION 
>   src/context/applets/covergrid/AlbumItem.cpp PRE-CREATION 
>   src/context/applets/covergrid/CMakeLists.txt PRE-CREATION 
>   src/context/applets/covergrid/CoverGridApplet.h PRE-CREATION 
>   src/context/applets/covergrid/CoverGridApplet.cpp PRE-CREATION 
>   src/context/applets/covergrid/amarok-context-applet-covergrid.desktop PRE-CREATION 
>   src/context/applets/covergrid/covergridSettings.ui PRE-CREATION 
>   src/context/applets/covergrid/defaultcover.png PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100841/diff
> 
> 
> Testing
> -------
> 
> basic functionalities seem to work
> 
> 
> Screenshots
> -----------
> 
> new applet in action
>   http://git.reviewboard.kde.org/r/100841/s/96/
> 
> 
> Thanks,
> 
> Manu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110604/58823acc/attachment.htm