Review Request: Expansion of MusicBrainz dialog

Sergey Ivanov 123kash at gmail.com
Wed Jan 26 01:19:00 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100443/#review1063
-----------------------------------------------------------


Check out latest git, there are some changes according to your e-mail. Made dialog a bit bigger, added buttons "Expand All", "Collapse All", "Expand Unchosen" and "Collapse Chosen" (only available for multi-track search), resize columns to content after search and finally added tooltip for 1st column (title), which selects best matches for all tracks (as I see no one know about this feature except me :-/ ).

- Sergey


On Jan. 25, 2011, 9:12 p.m., Felix Mauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100443/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2011, 9:12 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> I added automatic adjustment of all columns and expanding of all tracks for the MusicBrainz dialog. Unfortunately, I haven't been able yet to resize the dialog as well.
> 
> 
> Diffs
> -----
> 
>   src/dialogs/MusicBrainzTagger.cpp 297d610 
> 
> Diff: http://git.reviewboard.kde.org/r/100443/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Dialog after request (resized by hand)
>   http://git.reviewboard.kde.org/r/100443/s/54/
> 
> 
> Thanks,
> 
> Felix
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110126/c72e3f3c/attachment.html 


More information about the Amarok-devel mailing list