Review Request: Implements a preview button in the collection organizer dialog along with an "automatic preview" checkbox

[Maximilian Güntner]

> On Jan. 16, 2011, 12:09 p.m., Mark Kretschmann wrote:
> > Looks useful to me, but it seems to make the dialog very large - too large for e.g. Netbook devices. 
> > 
> > Is there a way to make it smaller?

It should not change the geometry and size at all since I've only added the buttons to the already existing box. When you compare the above screenshot with the organizer dialog shipped with amarok 2.4, you'll see that they are about the same size.


- Maximilian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100270/#review928
-----------------------------------------------------------


On Dec. 30, 2010, 9:34 p.m., Maximilian Güntner wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100270/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2010, 9:34 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> This patch adds manual preview functionality to the collection organizer dialog. This is very handy when altering the filename scheme and options of large collections ( > 1k files) since the dialog doesn't update the preview widget with every change in the filename configurator. The current functionality can be achieved by clicking on "Automatic Preview". Hope you like it.
> 
> 
> Diffs
> -----
> 
>   src/dialogs/OrganizeCollectionDialog.h f2ef834 
>   src/dialogs/OrganizeCollectionDialog.cpp b7d7850 
>   src/dialogs/OrganizeCollectionDialogBase.ui 2f28102 
> 
> Diff: http://git.reviewboard.kde.org/r/100270/diff
> 
> 
> Testing
> -------
> 
> -tested auto update by using/clicking each element that connects to the signalmapper
> -tested the manual preview button
> -moved a collection
> 
> 
> Screenshots
> -----------
> 
> Preview Button and auto preview checkbox
>   http://git.reviewboard.kde.org/r/100270/s/31/
> 
> 
> Thanks,
> 
> Maximilian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110120/64e4c02c/attachment.htm