Review Request: Filter Editor Dialog "restyling"

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100250/#review926
-----------------------------------------------------------

Ship it!


Sergey, I would say, go ahead and push it. If something feels wrong, we can still polish it (got enough time until 2.4.1).


- Mark


On Dec. 27, 2010, 12:58 p.m., Sergey Ivanov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100250/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2010, 12:58 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Polish "a bit" filter editor dialog, now It uses tokens as TagGuesser dialog does, and works exactly as Editor, not just like "appender" (260333 bug).
> 
> 
> This addresses bug 260333.
>     https://bugs.kde.org/show_bug.cgi?id=260333
> 
> 
> Diffs
> -----
> 
>   src/core/meta/support/MetaConstants.cpp e2e11a9 
>   src/dialogs/EditFilterDialog.h 12088bc 
>   src/dialogs/EditFilterDialog.cpp 67f1f6e 
>   src/dialogs/EditFilterDialog.ui 4b2bf3e 
>   src/images/icons/hi48-action-filename-and-amarok.png PRE-CREATION 
>   src/widgets/MetaQueryWidget.h 9c1181a 
>   src/widgets/MetaQueryWidget.cpp 8868106 
>   src/widgets/Token.h 134184f 
>   src/widgets/Token.cpp b672121 
>   src/widgets/TokenDropTarget.cpp c454fd4 
>   src/widgets/TokenPool.cpp 41d462d 
>   src/widgets/TokenWithLayout.h 744113e 
>   src/widgets/TokenWithLayout.cpp 4f581d8 
> 
> Diff: http://git.reviewboard.kde.org/r/100250/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/100250/s/30/
> 
> 
> Thanks,
> 
> Sergey
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110116/e0359efc/attachment.htm