<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100250/">http://git.reviewboard.kde.org/r/100250/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sergey, I would say, go ahead and push it. If something feels wrong, we can still polish it (got enough time until 2.4.1).
</pre>
<br />
<p>- Mark</p>
<br />
<p>On December 27th, 2010, 12:58 p.m., Sergey Ivanov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>
<p style="color: grey;"><i>Updated Dec. 27, 2010, 12:58 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Polish "a bit" filter editor dialog, now It uses tokens as TagGuesser dialog does, and works exactly as Editor, not just like "appender" (260333 bug).</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=260333">260333</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core/meta/support/MetaConstants.cpp <span style="color: grey">(e2e11a9)</span></li>
<li>src/dialogs/EditFilterDialog.h <span style="color: grey">(12088bc)</span></li>
<li>src/dialogs/EditFilterDialog.cpp <span style="color: grey">(67f1f6e)</span></li>
<li>src/dialogs/EditFilterDialog.ui <span style="color: grey">(4b2bf3e)</span></li>
<li>src/images/icons/hi48-action-filename-and-amarok.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/widgets/MetaQueryWidget.h <span style="color: grey">(9c1181a)</span></li>
<li>src/widgets/MetaQueryWidget.cpp <span style="color: grey">(8868106)</span></li>
<li>src/widgets/Token.h <span style="color: grey">(134184f)</span></li>
<li>src/widgets/Token.cpp <span style="color: grey">(b672121)</span></li>
<li>src/widgets/TokenDropTarget.cpp <span style="color: grey">(c454fd4)</span></li>
<li>src/widgets/TokenPool.cpp <span style="color: grey">(41d462d)</span></li>
<li>src/widgets/TokenWithLayout.h <span style="color: grey">(744113e)</span></li>
<li>src/widgets/TokenWithLayout.cpp <span style="color: grey">(4f581d8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100250/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100250/s/30/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/12/27/FilterEditor2_400x100.png" style="border: 1px black solid;" alt="" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>