Review Request: Reduce code duplication (combo box list)

[Alexander Potashev]

> On Jan. 8, 2011, 8:42 a.m., Mark Kretschmann wrote:
> > Looks good to me. At first I thought, this introduces string changes, we cannot do it before 2.4.0 release. But then I realized that you have just removed strings, but not changed any.
> > 
> > One nitpick: You should probably change "" to QString().

May I commit this patch myself to the repository? (after changing "" to QString())

I hope that I have write access to the repo. At least, I cloned it via git at git.kde.org:amarok.git.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100309/#review770
-----------------------------------------------------------


On Jan. 6, 2011, 8:27 p.m., Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100309/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2011, 8:27 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Reduce code duplication when filling in items of combo box.
> 
> 
> Diffs
> -----
> 
>   src/widgets/MetaQueryWidget.cpp 8868106 
> 
> Diff: http://git.reviewboard.kde.org/r/100309/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110108/57492fc8/attachment.htm