Review Request: Reduce code duplication (combo box list)

[Mark Kretschmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100309/#review770
-----------------------------------------------------------

Ship it!


Looks good to me. At first I thought, this introduces string changes, we cannot do it before 2.4.0 release. But then I realized that you have just removed strings, but not changed any.

One nitpick: You should probably change "" to QString().

- Mark


On 2011-01-06 20:27:28, Alexander Potashev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100309/
> -----------------------------------------------------------
> 
> (Updated 2011-01-06 20:27:28)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Reduce code duplication when filling in items of combo box.
> 
> 
> Diffs
> -----
> 
>   src/widgets/MetaQueryWidget.cpp 8868106 
> 
> Diff: http://git.reviewboard.kde.org/r/100309/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110108/ad967736/attachment-0001.htm