Review Request: File tag handler refactoring

[Lukas]

Great work :)

But the yellow and green hurts my eyes a bit. You could try to get some
matching, still dark enough colors with the help of  http://kuler.adobe.comor
http://colorschemedesigner.com. Also *bold* could help :)

On 7 January 2011 22:29, Sergey Ivanov <123kash at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100191/
>   Review request for Amarok.
> By Sergey Ivanov.
>
> *Updated 2011-01-07 20:29:46.128664*
> Changes
>
> Make It apply on latest git revision.
>
>   Description
>
> Rewrite tag reading stuff to make It more OOP way. Add separate classes for each Tag format (ID3v2, APE, ASF, VorbisComment, MP4, MPC). Exclude almost all "magic words" (frame/field names) from code.
> TODO:
> Implement charset detection stuff.
>
>   Diffs (updated)
>
>    - shared/FileType.h (dc5e57b)
>    - shared/FileType.cpp (63d81c7)
>    - shared/MetaTagLib.h (ff27c92)
>    - shared/MetaTagLib.cpp (90e2483)
>    - shared/TagsFromFileNameGuesser.h (PRE-CREATION)
>    - shared/TagsFromFileNameGuesser.cpp (PRE-CREATION)
>    - shared/tag_helpers/APETagHelper.h (PRE-CREATION)
>    - shared/tag_helpers/APETagHelper.cpp (PRE-CREATION)
>    - shared/tag_helpers/ASFTagHelper.h (PRE-CREATION)
>    - shared/tag_helpers/ASFTagHelper.cpp (PRE-CREATION)
>    - shared/tag_helpers/ID3v2TagHelper.h (PRE-CREATION)
>    - shared/tag_helpers/ID3v2TagHelper.cpp (PRE-CREATION)
>    - shared/tag_helpers/MP4TagHelper.h (PRE-CREATION)
>    - shared/tag_helpers/MP4TagHelper.cpp (PRE-CREATION)
>    - shared/tag_helpers/StringHelper.h (PRE-CREATION)
>    - shared/tag_helpers/StringHelper.cpp (PRE-CREATION)
>    - shared/tag_helpers/TagHelper.h (PRE-CREATION)
>    - shared/tag_helpers/TagHelper.cpp (PRE-CREATION)
>    - shared/tag_helpers/VorbisCommentTagHelper.h (PRE-CREATION)
>    - shared/tag_helpers/VorbisCommentTagHelper.cpp (PRE-CREATION)
>    - src/CMakeLists.txt (5dd4163)
>    - src/core-impl/meta/file/File_p.h (9f1df54)
>    - src/dialogs/FilenameLayoutDialog.h (0380cc1)
>    - src/dialogs/FilenameLayoutDialog.cpp (0efd23d)
>    - src/dialogs/FilenameLayoutDialog.ui (e75f407)
>    - src/dialogs/TagDialog.cpp (6b3d436)
>    - src/dialogs/TagGuesser.h (c3cc89f)
>    - src/dialogs/TagGuesser.cpp (869f432)
>    - src/musicbrainz/MusicBrainzFinder.cpp (78a07a6)
>    - utilities/collectionscanner/CMakeLists.txt (6be9319)
>
> View Diff <http://git.reviewboard.kde.org/r/100191/diff/>
> Screenshots
> [image: TagGuesser with full filepath]<http://git.reviewboard.kde.org/r/100191/s/25/>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110107/a3733d7d/attachment.htm