Great work :) <br><br>But the yellow and green hurts my eyes a bit. You could try to get some matching, still dark enough colors with the help of <a href="http://kuler.adobe.com">http://kuler.adobe.com</a> or <a href="http://colorschemedesigner.com">http://colorschemedesigner.com</a>. Also <b>bold</b> could help :)<br>
<br><div class="gmail_quote">On 7 January 2011 22:29, Sergey Ivanov <span dir="ltr"><<a href="mailto:123kash@gmail.com">123kash@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div>
<div style="font-family: Verdana,Arial,Helvetica,Sans-Serif;">
<table style="border: 1px solid rgb(201, 195, 153);" cellpadding="8" width="100%" bgcolor="#f9f3c9">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100191/" target="_blank">http://git.reviewboard.kde.org/r/100191/</a>
</td>
</tr>
</tbody></table>
<br>
<table style="background-repeat: repeat-x; border: 1px solid black;" cellpadding="8" cellspacing="0" width="100%" bgcolor="#fefadf">
<tbody><tr>
<td>
<div>Review request for Amarok.</div>
<div>By Sergey Ivanov.</div>
<p style="color: grey;"><i>Updated 2011-01-07 20:29:46.128664</i></p>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table style="border: 1px solid rgb(184, 181, 160);" cellpadding="10" cellspacing="0" width="100%" bgcolor="#ffffff">
<tbody><tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">Make It apply on latest git revision.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table style="border: 1px solid rgb(184, 181, 160);" cellpadding="10" cellspacing="0" width="100%" bgcolor="#ffffff">
<tbody><tr>
<td>
<pre style="margin: 0pt; padding: 0pt; white-space: pre-wrap; word-wrap: break-word;">Rewrite tag reading stuff to make It more OOP way. Add separate classes for each Tag format (ID3v2, APE, ASF, VorbisComment, MP4, MPC). Exclude almost all "magic words" (frame/field names) from code.
TODO:
Implement charset detection stuff.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Diffs (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0pt;">
<li>shared/FileType.h <span style="color: grey;">(dc5e57b)</span></li>
<li>shared/FileType.cpp <span style="color: grey;">(63d81c7)</span></li>
<li>shared/MetaTagLib.h <span style="color: grey;">(ff27c92)</span></li>
<li>shared/MetaTagLib.cpp <span style="color: grey;">(90e2483)</span></li>
<li>shared/TagsFromFileNameGuesser.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/TagsFromFileNameGuesser.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/APETagHelper.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/APETagHelper.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ASFTagHelper.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ASFTagHelper.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/ID3v2TagHelper.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/MP4TagHelper.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/MP4TagHelper.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/StringHelper.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/StringHelper.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/TagHelper.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/TagHelper.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.h <span style="color: grey;">(PRE-CREATION)</span></li>
<li>shared/tag_helpers/VorbisCommentTagHelper.cpp <span style="color: grey;">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey;">(5dd4163)</span></li>
<li>src/core-impl/meta/file/File_p.h <span style="color: grey;">(9f1df54)</span></li>
<li>src/dialogs/FilenameLayoutDialog.h <span style="color: grey;">(0380cc1)</span></li>
<li>src/dialogs/FilenameLayoutDialog.cpp <span style="color: grey;">(0efd23d)</span></li>
<li>src/dialogs/FilenameLayoutDialog.ui <span style="color: grey;">(e75f407)</span></li>
<li>src/dialogs/TagDialog.cpp <span style="color: grey;">(6b3d436)</span></li>
<li>src/dialogs/TagGuesser.h <span style="color: grey;">(c3cc89f)</span></li>
<li>src/dialogs/TagGuesser.cpp <span style="color: grey;">(869f432)</span></li>
<li>src/musicbrainz/MusicBrainzFinder.cpp <span style="color: grey;">(78a07a6)</span></li>
<li>utilities/collectionscanner/CMakeLists.txt <span style="color: grey;">(6be9319)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100191/diff/" style="margin-left: 3em;" target="_blank">View Diff</a></p>
<h1 style="color: rgb(87, 80, 18); font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/100191/s/25/" target="_blank"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2010/12/20/TagGuesser_400x100.png" style="border: 1px solid black;" alt="TagGuesser with full filepath"></a>
</div>
</td>
</tr>
</tbody></table>
</div>
</div>
</blockquote></div>