Review Request: Refactoring of tag dialog, remove statistics pane
Ralf Engels
ralf-engels at gmx.de
Sun Feb 27 12:27:42 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100758/
-----------------------------------------------------------
Review request for Amarok.
Summary
-------
After discussion with Markey
Statistics pane was remove
Editing of rating and score was moved to summary page.
Other meta information (albums from same artist) were removed as this functionality is covered by the context applets and does not belong to a tag edit dialog
New functionality: if editing multiple tracks from same album the album cover can still be edited and the summary page shows the total lenght and total size of all tracks.
Diffs
-----
src/dialogs/LabelListModel.h 45dd577
src/dialogs/LabelListModel.cpp 565da03
src/dialogs/TagDialog.h 887eeaf
src/dialogs/TagDialog.cpp 71eba59
src/dialogs/TagDialogBase.ui cdf33dd
Diff: http://git.reviewboard.kde.org/r/100758/diff
Testing
-------
Editing with one and multiple tracks.
Adding, removing labels.
Switching between "per Track" and multiple tracks mode and editing various tags.
Thanks,
Ralf
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110227/8c507eaa/attachment.htm
More information about the Amarok-devel
mailing list