Review Request: Some Jamendo artists don't appear in the Jamendo service

[Wolfgang Lorenz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100742/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

The Amarok Jamendo-Plugin ignores albums, that come without a genre. As these are rather many, this seems not advisable (see Bug 235184).

This patch simply "unignores" albums without genre. The problem here is, it makes Amarok freeze, when it comes to showing the contents of the "Unknown genre"-Section, because the SQL query takes a very long time - more than an hour on my computer (see Bug 267065).

The second thing, this patch does is to write out the SQL-queries in debug mode.

Note: To search the database you still might need to apply patch https://git.reviewboard.kde.org/r/100723/ (for Bug 233170)
Also Note: At the moment, this patch is really only for testing purposes.


This addresses bugs 235184 and 267065.
    https://bugs.kde.org/show_bug.cgi?id=235184
    https://bugs.kde.org/show_bug.cgi?id=267065


Diffs
-----

  src/services/ServiceSqlQueryMaker.cpp 2cb1242 
  src/services/jamendo/JamendoXmlParser.cpp b8735e8 

Diff: http://git.reviewboard.kde.org/r/100742/diff


Testing
-------


Thanks,

Wolfgang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110225/9830ce8f/attachment.htm