<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100742/">http://git.reviewboard.kde.org/r/100742/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Wolfgang Lorenz.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Amarok Jamendo-Plugin ignores albums, that come without a genre. As these are rather many, this seems not advisable (see Bug 235184).
This patch simply "unignores" albums without genre. The problem here is, it makes Amarok freeze, when it comes to showing the contents of the "Unknown genre"-Section, because the SQL query takes a very long time - more than an hour on my computer (see Bug 267065).
The second thing, this patch does is to write out the SQL-queries in debug mode.
Note: To search the database you still might need to apply patch https://git.reviewboard.kde.org/r/100723/ (for Bug 233170)
Also Note: At the moment, this patch is really only for testing purposes.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=235184">235184</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=267065">267065</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/services/ServiceSqlQueryMaker.cpp <span style="color: grey">(2cb1242)</span></li>
<li>src/services/jamendo/JamendoXmlParser.cpp <span style="color: grey">(b8735e8)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100742/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>