Review Request: Fix "smb" and "nfs" remote collections to work with Dynamic Collections

[Peter C. Ndikuwera]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100725/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

Used MassStorageDeviceHandler as a template, then changed the following:

SQLStorage - should use StorageAccess instead of StorageVolume. StorageVolume only sees physical volumes on the local PC. StorageAccess sees all accessible storage.

NFS & SMS DeviceHandlers use KMountPoint to find where the disk is mounted.


Diffs
-----

  src/core-impl/collections/db/sql/MountPointManager.cpp ed29f48 
  src/core-impl/collections/db/sql/device/CMakeLists.txt 1baaf85 
  src/core-impl/collections/db/sql/device/nfs/CMakeLists.txt 6807dd6 
  src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.h 21c1894 
  src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.cpp 91af710 
  src/core-impl/collections/db/sql/device/smb/CMakeLists.txt fc27d5a 
  src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.h c74c840 
  src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.cpp 2f19e28 

Diff: http://git.reviewboard.kde.org/r/100725/diff


Testing
-------

Mounted nfs and samba/cifs shares and did full rescans. Then unmounted them one by one. Works perfectly.

Haven't tested what happens if you mount a share that's _not_ in /etc/fstab.


Thanks,

Peter C.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/amarok-devel/attachments/20110223/cc95556b/attachment-0001.htm