<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100725/">http://git.reviewboard.kde.org/r/100725/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Amarok.</div>
<div>By Peter C. Ndikuwera.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Used MassStorageDeviceHandler as a template, then changed the following:
SQLStorage - should use StorageAccess instead of StorageVolume. StorageVolume only sees physical volumes on the local PC. StorageAccess sees all accessible storage.
NFS & SMS DeviceHandlers use KMountPoint to find where the disk is mounted.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Mounted nfs and samba/cifs shares and did full rescans. Then unmounted them one by one. Works perfectly.
Haven't tested what happens if you mount a share that's _not_ in /etc/fstab.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/core-impl/collections/db/sql/MountPointManager.cpp <span style="color: grey">(ed29f48)</span></li>
<li>src/core-impl/collections/db/sql/device/CMakeLists.txt <span style="color: grey">(1baaf85)</span></li>
<li>src/core-impl/collections/db/sql/device/nfs/CMakeLists.txt <span style="color: grey">(6807dd6)</span></li>
<li>src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.h <span style="color: grey">(21c1894)</span></li>
<li>src/core-impl/collections/db/sql/device/nfs/NfsDeviceHandler.cpp <span style="color: grey">(91af710)</span></li>
<li>src/core-impl/collections/db/sql/device/smb/CMakeLists.txt <span style="color: grey">(fc27d5a)</span></li>
<li>src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.h <span style="color: grey">(c74c840)</span></li>
<li>src/core-impl/collections/db/sql/device/smb/SmbDeviceHandler.cpp <span style="color: grey">(2f19e28)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100725/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>