2.5.0 tarball problems

[Modestas Vainius]

Hello,

On šeštadienis 17 Gruodis 2011 23:33:18 Matěj Laitl wrote:
> On 17. 12. 2011 Modestas Vainius wrote:
> > current 2.5.0 tarball does not build. The problem is in the doc/nl (could
> > be related to kdelibs 4.6.5):
> > 
> > cd ../doc/nl && /usr/bin/meinproc4 --check --cache
> > /«PKGBUILDDIR»/obj-x86_64- linux-gnu/doc/nl/index.cache.bz2
> > /«PKGBUILDDIR»/doc/nl/index.docbook Generating moc_BiasSolver.cpp
> > index.docbook:21: parser error : Entity 'Thom.Castermans' not defined
> > index.docbook:13966: parser error : Entity 'vertaling.thom' not defined
> 
> We have found the root of this problem:
> 1. amarok-2.5.0/doc/nl/index.docbook references entity &Thom.Castermans
> 
> 2. meinproc4 that generates HTML from docbook during Amarok build uses
> /usr/share/apps/ksgmltools2/customization/nl/user.entities to load such
> entities (among other files) through:
>  * ksgmltools2/customization/catalog.xml ->
>  -> ksgmltools2/customization/nl/catalog.xml ->
>  -> ksgmltools2/customization/nl/
> 
> 3. ksgmltools2/customization/nl/user.entities is from kdelibs, and Thom had
> no entry there in kdelibs 4.6 as he was added to kdelibs
> 
> Which is rather unfortunate (and silly as we didn't spot it before
> spreading tarballs) as it effectively breaks Amarok build on KDE 4.6 which
> we support.
> 
> The simplest workaround is probably to remove all undefined references from
> doc/nl/index.docbook at the cost of not attributing Thom as a docbook
> translator in your build.

So a broken amarok 2.5.0 tarball was released to the public. Unfortunately, 
this has been happening a lot with amarok recently... Oh well, in case 
somebody is interested, the patch is attached.

-- 
Modestas Vainius <modax at debian.org>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: debian_fix_doc_nl_build.diff
Type: text/x-patch
Size: 792 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111226/24123473/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20111226/24123473/attachment.sig>