Review Request: Fix translation in EditFilterDialog filter string

Sergey Ivanov 123kash at gmail.com
Sat Aug 27 09:03:56 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102443/#review6047
-----------------------------------------------------------

Ship it!


There is nothing to review, just commit It. Don't forget about changelog. :)

- Sergey


On Aug. 26, 2011, 10:58 a.m., Nikhil Shantanu Marathe wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102443/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2011, 10:58 a.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Use combobox item index to decide whether to use AND/OR rather than getting translated string from combobox
> 
> 
> This addresses bug 279559.
>     https://bugs.kde.org/show_bug.cgi?id=279559
> 
> 
> Diffs
> -----
> 
>   src/dialogs/EditFilterDialog.h 8a91505 
>   src/dialogs/EditFilterDialog.cpp eb59f27 
> 
> Diff: http://git.reviewboard.kde.org/r/102443/diff
> 
> 
> Testing
> -------
> 
> No :( I don't have translations installed and can't seem to get them to work, but the logic is correct, and works in the English amarok.
> 
> 
> Thanks,
> 
> Nikhil Shantanu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110827/08a0b970/attachment-0001.html>


More information about the Amarok-devel mailing list