Review Request: Fix translation in EditFilterDialog filter string

Nikhil Shantanu Marathe nsm.nikhil at gmail.com
Fri Aug 26 10:58:14 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102443/
-----------------------------------------------------------

Review request for Amarok.


Summary
-------

Use combobox item index to decide whether to use AND/OR rather than getting translated string from combobox


This addresses bug 279559.
    https://bugs.kde.org/show_bug.cgi?id=279559


Diffs
-----

  src/dialogs/EditFilterDialog.h 8a91505 
  src/dialogs/EditFilterDialog.cpp eb59f27 

Diff: http://git.reviewboard.kde.org/r/102443/diff


Testing
-------

No :( I don't have translations installed and can't seem to get them to work, but the logic is correct, and works in the English amarok.


Thanks,

Nikhil Shantanu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110826/361e8ff0/attachment.html>


More information about the Amarok-devel mailing list