Review Request: Visualization with projectM

Alessandro Siniscalchi asiniscalchi at gmail.com
Thu Aug 25 09:23:02 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102277/
-----------------------------------------------------------

(Updated Aug. 25, 2011, 9:23 a.m.)


Review request for Amarok.


Summary
-------

It add Amarok the visualization using projectM.

It uses the git of Phonon cause audioDataOutput is fixed in the gstreamer backend.

TODO: disconnection of audioDataPath make the audio path disconnect too... Phonon bug ?


Diffs
-----

  src/EngineController.h 3da2f239c64614491937e883ccb4a2d4ed29366d 
  src/CMakeLists.txt e0cf2ba041cf42bc5c72d05fb08cf52afd789a04 
  src/EngineController.cpp 5bea5c6e148de9cd440e479871c6f23497d7ad44 
  src/MainWindow.h 076628f4b1c12d094b761867c600de2746d076bf 
  src/MainWindow.cpp 2d2ebacce172fffaaf313294b690424e827b800b 
  src/audiodatacenter/CMakeLists.txt PRE-CREATION 
  src/audiodatacenter/audiodatacenter.h PRE-CREATION 
  src/audiodatacenter/audiodatacenter.cpp PRE-CREATION 
  src/audiodatacenter/audiodataclient.h PRE-CREATION 
  src/audiodatacenter/audiodataclient.cpp PRE-CREATION 
  src/visualm/CMakeLists.txt PRE-CREATION 
  src/visualm/visualm.h PRE-CREATION 
  src/visualm/visualm.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102277/diff


Testing
-------


Screenshots
-----------


  http://git.reviewboard.kde.org/r/102277/s/222/


Thanks,

Alessandro

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110825/9ab29a39/attachment.html>


More information about the Amarok-devel mailing list