Review Request: Add a CMake switch for building playground

[Kevin Funk]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102077/#review5574
-----------------------------------------------------------

Ship it!


Looks fine, I don't see any reasons against this. And I'm glad you fixed the playground/CMakeLists.txt. I had a local fix for this lying around for this as well.

- Kevin


On July 24, 2011, 6:29 p.m., Martin Blumenstingl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102077/
> -----------------------------------------------------------
> 
> (Updated July 24, 2011, 6:29 p.m.)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> It seems that up to now everyone who tried to build playground had to do evil workarounds.
> 
> Since CMake is quite nice I wrote a small fix for it.
> It's now possible to enable/disable building playground via a small CMake switch.
> By default this switch is set to OFF.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 0c2e958 
>   playground/CMakeLists.txt 4cd4052 
> 
> Diff: http://git.reviewboard.kde.org/r/102077/diff
> 
> 
> Testing
> -------
> 
> The coverbling applet installs successful if playground is enabled.
> I did not test anything else (except disabling the switch again and seeing if the coverbling applet is now excluded).
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/amarok-devel/attachments/20110810/43d19104/attachment-0001.html>